From b35573c6b51c1a92ab5c6e5319ffb89c279858c9 Mon Sep 17 00:00:00 2001
From: Phantasm <phantasm@centrum.cz>
Date: Mon, 12 Jan 2026 19:35:12 +0100
Subject: [PATCH] Elixir 1.19: Warn on adding :console to Logger backends

Logger.Backend.Console still exists, but it is unused in our
configuration. Instead logging to console is done from Logger's
"default_handler".
---
 lib/pleroma/application.ex        | 28 +++++++++++++++++++---------
 test/pleroma/application_test.exs | 11 +++++++++++
 2 files changed, 30 insertions(+), 9 deletions(-)

diff --git a/lib/pleroma/application.ex b/lib/pleroma/application.ex
index 1e80c62491..0e8723251d 100644
--- a/lib/pleroma/application.ex
+++ b/lib/pleroma/application.ex
@@ -117,27 +117,37 @@ defmodule Pleroma.Application do
   def configure_logger do
     Config.get([:logger, :backends], [])
     |> Enum.each(fn backend ->
-      backend = backend_to_logger(backend)
+      case backend_to_logger(backend) do
+        {:ok, logger} ->
+          add_logger(logger)
 
-      case LoggerBackends.add(backend) do
-        {:ok, _} ->
-          Logger.debug("Successfully added logger backend: #{inspect(backend)}")
-
-        {:error, reason} ->
-          Logger.error("Failed to add logger backend #{inspect(backend)}: #{inspect(reason)}")
+        {:error, :console_backend} ->
+          Logger.warning(":console is no longer considered a backend and is enabled by default")
       end
     end)
   end
 
+  defp add_logger(backend) do
+    case LoggerBackends.add(backend) do
+      {:ok, _} ->
+        Logger.debug("Successfully added logger backend: #{inspect(backend)}")
+
+      {:error, reason} ->
+        Logger.error("Failed to add logger backend #{inspect(backend)}: #{inspect(reason)}")
+    end
+  end
+
+  defp backend_to_logger(:console), do: {:error, :console_backend}
+
   defp backend_to_logger({:ex_syslogger = backend, name}) do
     Logger.warning(
       "Configuration {:#{backend}, :#{name}} is incorrect. Use {ExSyslogger, :#{name}} instead!"
     )
 
-    {ExSyslogger, name}
+    {:ok, {ExSyslogger, name}}
   end
 
-  defp backend_to_logger(backend), do: backend
+  defp backend_to_logger(backend), do: {:ok, backend}
 
   def load_custom_modules do
     dir = Config.get([:modules, :runtime_dir])
diff --git a/test/pleroma/application_test.exs b/test/pleroma/application_test.exs
index afe6287328..48f87818f4 100644
--- a/test/pleroma/application_test.exs
+++ b/test/pleroma/application_test.exs
@@ -19,4 +19,15 @@ defmodule Pleroma.ApplicationTest do
       assert log =~ "Successfully added logger backend: {ExSyslogger, :ex_syslogger}"
     end
   end
+
+  describe "config :pleroma, :logger, :backends: [:console]" do
+    setup do
+      clear_config([:logger, :backends], [:console])
+    end
+
+    test "emits a warning" do
+      assert capture_log(fn -> Pleroma.Application.configure_logger() end) =~
+        ":console is no longer considered a backend and is enabled by default"
+    end
+  end
 end